Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2437053002: Catch bad display sizes. (Closed)

Created:
4 years, 2 months ago by kylechar
Modified:
4 years, 2 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch bad display sizes. Display resolution with zero for either width or height aren't valid. Catch this problem and fail parsing the display spec string. BUG=none Committed: https://crrev.com/743ebef08d2752a58c13c733114eacc872cebb2e Cr-Commit-Position: refs/heads/master@{#426491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/display/fake_display_snapshot.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/display/fake_display_snapshot_unittests.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kylechar
4 years, 2 months ago (2016-10-20 13:59:04 UTC) #2
Daniel Erat
lgtm
4 years, 2 months ago (2016-10-20 15:16:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437053002/1
4 years, 2 months ago (2016-10-20 15:17:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 16:19:14 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:18:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/743ebef08d2752a58c13c733114eacc872cebb2e
Cr-Commit-Position: refs/heads/master@{#426491}

Powered by Google App Engine
This is Rietveld 408576698