Issue 2437003003: Access SigninErrorProvider through ChromeBrowserProvider.

Issue 2437003003: Access SigninErrorProvider through ChromeBrowserProvider. (Closed)

Created:
4 years, 2 months ago by sdefresne

Modified:
4 years, 2 months ago

Reviewers:
bzanotti

CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Access SigninErrorProvider through ChromeBrowserProvider. BUG=475439 Committed: https://crrev.com/ddad288b54125152cf7038126c5f8cd9ca04710a Cr-Commit-Position: refs/heads/master@{#426485}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -9 lines)			Patch
M	ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	ios/chrome/browser/signin/signin_util.mm	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ios/public/provider/chrome/browser/chrome_browser_provider.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	ios/public/provider/chrome/browser/chrome_browser_provider.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ios/public/provider/chrome/browser/signin/fake_chrome_identity_interaction_manager.mm	View	2 chunks	+3 lines, -1 line	0 comments	Download

Dependent Patchsets:

Total messages: 12 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437003003/1

4 years, 2 months ago (2016-10-20 15:17:52 UTC) #8

sdefresne

A revert of this CL (patchset #1 id:1) has been created in https://chromiumcodereview.appspot.com/2435053003/ by sdefresne@chromium.org. ...

4 years, 2 months ago (2016-10-20 19:17:14 UTC) #10

commit-bot: I haz the power

4 years, 2 months ago (2016-10-21 13:18:36 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ddad288b54125152cf7038126c5f8cd9ca04710a
Cr-Commit-Position: refs/heads/master@{#426485}