[stubs] Cleanup CSA::BitFieldDecode() and friends.

src/builtins/builtins-object.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/code-factory.h"
 #include "src/property-descriptor.h"
 
@@ skipping 470 matching lines @@
     // Check that we have a simple object
     a->GotoIf(a->TaggedIsSmi(properties), &call_runtime);
     // Undefined implies no properties.
     a->GotoIf(a->WordEqual(properties, a->UndefinedConstant()), &no_properties);
     Node* properties_map = a->LoadMap(properties);
     a->GotoIf(a->IsSpecialReceiverMap(properties_map), &call_runtime);
     // Stay on the fast path only if there are no elements.
     a->GotoUnless(a->WordEqual(a->LoadElements(properties),
                                a->LoadRoot(Heap::kEmptyFixedArrayRootIndex)),
                   &call_runtime);
-    // Jump to the runtime for slow objects.
+    // Handle dictionary objects or fast objects with properties in runtime.
     Node* bit_field3 = a->LoadMapBitField3(properties_map);
-    Node* is_fast_map = a->Word32Equal(
-        a->BitFieldDecode<Map::DictionaryMap>(bit_field3), a->Int32Constant(0));
-    a->GotoUnless(is_fast_map, &call_runtime);
-
-    a->Branch(
-        a->WordEqual(
-            a->BitFieldDecodeWord<Map::NumberOfOwnDescriptorsBits>(bit_field3),
-            a->IntPtrConstant(0)),
-        &no_properties, &call_runtime);
+    a->GotoIf(a->IsSetWord32<Map::DictionaryMap>(bit_field3), &call_runtime);
+    a->Branch(a->IsSetWord32<Map::NumberOfOwnDescriptorsBits>(bit_field3),
+              &call_runtime, &no_properties);
   }
 
   // Create a new object with the given prototype.
   a->Bind(&no_properties);
   {
     Variable map(a, MachineRepresentation::kTagged);
     Label non_null_proto(a), instantiate_map(a), good(a);
 
     a->Branch(a->WordEqual(prototype, a->NullConstant()), &good,
               &non_null_proto);
@@ skipping 540 matching lines @@
   typedef CompareDescriptor Descriptor;
   Node* object = assembler->Parameter(Descriptor::kLeft);
   Node* callable = assembler->Parameter(Descriptor::kRight);
   Node* context = assembler->Parameter(Descriptor::kContext);
 
   assembler->Return(assembler->InstanceOf(object, callable, context));
 }
 
 }  // namespace internal
 }  // namespace v8