Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2436893002: [Extensions] Convert some callers of ModuleSystem::CallModuleMethod (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some callers of ModuleSystem::CallModuleMethod ModuleSystem::CallModuleMethod is deprecated (see bug for more info). Convert some callers to use ModuleSystem::CallModuleMethodSafe. BUG=629431 Committed: https://crrev.com/389e45df0fc5fcebbc651eea8daa72f3989914a6 Cr-Commit-Position: refs/heads/master@{#426357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/messaging_bindings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/module_system.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
4 years, 2 months ago (2016-10-19 22:47:26 UTC) #7
lazyboy
lgtm
4 years, 2 months ago (2016-10-19 23:15:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436893002/1
4 years, 2 months ago (2016-10-20 00:11:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 00:40:55 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:14:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/389e45df0fc5fcebbc651eea8daa72f3989914a6
Cr-Commit-Position: refs/heads/master@{#426357}

Powered by Google App Engine
This is Rietveld 408576698