Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2436873003: Forward declare test class as friend of SpeechInputLocaleConfigImpl. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 2 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward declare test class as friend of SpeechInputLocaleConfigImpl. SpeechInputLocaleConfigImplTest wants to create a local instance of SpeechInputLocaleConfigImpl (to avoid pollution by other tests) so declare it as friend class. BUG=656617 Committed: https://crrev.com/22b6c6a2de2c7ec45d547ffca4aebc9739fba3c4 Cr-Commit-Position: refs/heads/master@{#426341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/browser/voice/speech_input_locale_config_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sdefresne
Please take a look and send to CQ if lgty.
4 years, 2 months ago (2016-10-19 23:04:11 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years, 2 months ago (2016-10-19 23:07:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436873003/1
4 years, 2 months ago (2016-10-19 23:08:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 23:54:57 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:13:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22b6c6a2de2c7ec45d547ffca4aebc9739fba3c4
Cr-Commit-Position: refs/heads/master@{#426341}

Powered by Google App Engine
This is Rietveld 408576698