[Sync] Move events files around a bit.

[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
TBR=bauerb

Committed: https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af
Cr-Commit-Position: refs/heads/master@{#426866}

[maxbogue, 2016-10-21 00:56:37]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 00:58:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 01:04:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:04:13]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[maxbogue, 2016-10-21 06:56:27]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 06:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-21 07:03:52]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-10-21 07:03:53]

Sky, PTAL! This one just shuffles some files into better places.

[commit-bot: I haz the power, 2016-10-21 08:17:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 08:17:45]

Dry run: This issue passed the CQ dry run.

[skym, 2016-10-21 13:56:51]

lgtm

https://codereview.chromium.org/2436863005/diff/20001/components/sync/engine_...
File components/sync/engine_impl/events/clear_server_data_request_event.h
(right):

https://codereview.chromium.org/2436863005/diff/20001/components/sync/engine_...
components/sync/engine_impl/events/clear_server_data_request_event.h:6: #define
COMPONENTS_SYNC_ENGINE_IMPL_EVENTS_CLEAR_SERVER_DATA_REQUEST_EVENT_H_
This is weird. The diff tool decides to highlight in bright green different
sided underscores around IMPL for these two lines.

[maxbogue, 2016-10-21 17:02:41]

https://codereview.chromium.org/2436863005/diff/20001/components/sync/engine_...
File components/sync/engine_impl/events/clear_server_data_request_event.h
(right):

https://codereview.chromium.org/2436863005/diff/20001/components/sync/engine_...
components/sync/engine_impl/events/clear_server_data_request_event.h:6: #define
COMPONENTS_SYNC_ENGINE_IMPL_EVENTS_CLEAR_SERVER_DATA_REQUEST_EVENT_H_
On 2016/10/21 13:56:50, skym wrote:
> This is weird. The diff tool decides to highlight in bright green different
> sided underscores around IMPL for these two lines.

Strange; it doesn't for me >_>

[maxbogue, 2016-10-21 17:02:49]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-10-21 17:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-21 18:56:26]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-10-21 18:57:40]

maxbogue@chromium.org changed reviewers:
+ bauerb@chromium.org

[maxbogue, 2016-10-21 18:57:40]

TBR bauerb@ for chrome/browser/ui/webui/

[maxbogue, 2016-10-21 18:57:54]

Description was changed from

==========
[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
==========

to

==========
[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
TBR=bauerb
==========

[maxbogue, 2016-10-21 18:58:00]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-10-21 18:58:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 19:43:19]

Description was changed from

==========
[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
TBR=bauerb
==========

to

==========
[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
TBR=bauerb
==========

[commit-bot: I haz the power, 2016-10-21 19:43:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 20:00:03]

Description was changed from

==========
[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
TBR=bauerb
==========

to

==========
[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
TBR=bauerb

Committed: https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af
Cr-Commit-Position: refs/heads/master@{#426866}
==========

[commit-bot: I haz the power, 2016-10-21 20:00:04]

Patchset 2 (id:??) landed as
https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af
Cr-Commit-Position: refs/heads/master@{#426866}

[Bernhard Bauer, 2016-10-22 16:46:03]

RS LGTM