Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2436833002: Send POST request to update WebAPK instead of PUT request (Closed)

Created:
4 years, 2 months ago by pkotwicz
Modified:
4 years, 2 months ago
Reviewers:
dominickn
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send POST request to update WebAPK instead of PUT request BUG=None TEST=Manual Committed: https://crrev.com/88eb893d11a0cd4d9103c459f17fb04c8ccd932e Cr-Commit-Position: refs/heads/master@{#426538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/android/webapk/webapk_installer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/webapk/webapk_installer.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
Dominick can you please take a look? This is something that I missed in https://codereview.chromium.org/2408263002/
4 years, 2 months ago (2016-10-19 17:48:33 UTC) #2
dominickn
lgtm
4 years, 2 months ago (2016-10-19 23:11:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436833002/1
4 years, 2 months ago (2016-10-20 17:35:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 18:33:40 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:20:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88eb893d11a0cd4d9103c459f17fb04c8ccd932e
Cr-Commit-Position: refs/heads/master@{#426538}

Powered by Google App Engine
This is Rietveld 408576698