Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2436813003: [turbofan] splinters should spill if there is no register use (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] splinters should spill if there is no register use When allocating for splinters, we were prematurely reverting to the hot range behavior, even when the range didn't actually have any positions requiring a register. This could cause unnecessary moves. BUG= Committed: https://crrev.com/d2784b985fd4289a5cdeaa4c6dafa15c6f885aa4 Cr-Commit-Position: refs/heads/master@{#40472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/compiler/register-allocator.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mircea Trofin
4 years, 2 months ago (2016-10-19 18:24:59 UTC) #5
Jarin
lgtm
4 years, 2 months ago (2016-10-20 11:11:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436813003/1
4 years, 2 months ago (2016-10-20 14:13:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 14:18:00 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2784b985fd4289a5cdeaa4c6dafa15c6f885aa4
Cr-Commit-Position: refs/heads/master@{#40472}

Powered by Google App Engine
This is Rietveld 408576698