Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2436783003: [inspector] fix UAF in another part of console code (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fix UAF in another part of console code BUG=chromium:656823 R=dgozman@chromium.org Committed: https://crrev.com/820811f5820377c7f9ab677959a8059e2656803e Cr-Commit-Position: refs/heads/master@{#40484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/inspector/v8-console-message.cc View 5 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kozy
Dmitry, please take a look! There is one more UAF on bug tracker. We need ...
4 years, 2 months ago (2016-10-20 00:14:04 UTC) #1
dgozman
Can we have a test? lgtm
4 years, 2 months ago (2016-10-20 20:57:00 UTC) #2
kozy
Yes, external contributor is working on making possible to detach context in inspector test runner. ...
4 years, 2 months ago (2016-10-20 21:03:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436783003/1
4 years, 2 months ago (2016-10-20 21:03:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 21:35:41 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/820811f5820377c7f9ab677959a8059e2656803e
Cr-Commit-Position: refs/heads/master@{#40484}

Powered by Google App Engine
This is Rietveld 408576698