Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Side by Side Diff: components/arc/arc_service_manager.cc

Issue 2436763004: More graceful shutdown for ArcSession. (Closed)
Patch Set: Add StopArcInstance Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/arc/arc_bridge_service_unittest.cc ('k') | components/arc/arc_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/arc_service_manager.h" 5 #include "components/arc/arc_service_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 : blocking_task_runner_(blocking_task_runner), 44 : blocking_task_runner_(blocking_task_runner),
45 icon_loader_(new ActivityIconLoader), 45 icon_loader_(new ActivityIconLoader),
46 activity_resolver_(new LocalActivityResolver) { 46 activity_resolver_(new LocalActivityResolver) {
47 DCHECK(!g_arc_service_manager); 47 DCHECK(!g_arc_service_manager);
48 g_arc_service_manager = this; 48 g_arc_service_manager = this;
49 49
50 if (g_arc_bridge_service_for_testing) { 50 if (g_arc_bridge_service_for_testing) {
51 arc_bridge_service_.reset(g_arc_bridge_service_for_testing); 51 arc_bridge_service_.reset(g_arc_bridge_service_for_testing);
52 g_arc_bridge_service_for_testing = nullptr; 52 g_arc_bridge_service_for_testing = nullptr;
53 } else { 53 } else {
54 arc_bridge_service_.reset(new ArcBridgeServiceImpl()); 54 arc_bridge_service_.reset(new ArcBridgeServiceImpl(blocking_task_runner));
55 } 55 }
56 56
57 AddService(base::MakeUnique<ArcAudioBridge>(arc_bridge_service())); 57 AddService(base::MakeUnique<ArcAudioBridge>(arc_bridge_service()));
58 AddService(base::MakeUnique<ArcBluetoothBridge>(arc_bridge_service())); 58 AddService(base::MakeUnique<ArcBluetoothBridge>(arc_bridge_service()));
59 AddService(base::MakeUnique<ArcBootPhaseMonitorBridge>(arc_bridge_service())); 59 AddService(base::MakeUnique<ArcBootPhaseMonitorBridge>(arc_bridge_service()));
60 AddService(base::MakeUnique<ArcClipboardBridge>(arc_bridge_service())); 60 AddService(base::MakeUnique<ArcClipboardBridge>(arc_bridge_service()));
61 AddService(base::MakeUnique<ArcCrashCollectorBridge>(arc_bridge_service(), 61 AddService(base::MakeUnique<ArcCrashCollectorBridge>(arc_bridge_service(),
62 blocking_task_runner_)); 62 blocking_task_runner_));
63 AddService(base::MakeUnique<ArcImeService>(arc_bridge_service())); 63 AddService(base::MakeUnique<ArcImeService>(arc_bridge_service()));
64 AddService(base::MakeUnique<ArcMetricsService>(arc_bridge_service())); 64 AddService(base::MakeUnique<ArcMetricsService>(arc_bridge_service()));
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 std::unique_ptr<BooleanPrefMember> arc_enabled_pref) { 100 std::unique_ptr<BooleanPrefMember> arc_enabled_pref) {
101 DCHECK(thread_checker_.CalledOnValidThread()); 101 DCHECK(thread_checker_.CalledOnValidThread());
102 AddService(base::MakeUnique<ArcNotificationManager>(arc_bridge_service(), 102 AddService(base::MakeUnique<ArcNotificationManager>(arc_bridge_service(),
103 account_id)); 103 account_id));
104 } 104 }
105 105
106 void ArcServiceManager::Shutdown() { 106 void ArcServiceManager::Shutdown() {
107 icon_loader_ = nullptr; 107 icon_loader_ = nullptr;
108 activity_resolver_ = nullptr; 108 activity_resolver_ = nullptr;
109 services_.clear(); 109 services_.clear();
110 arc_bridge_service_->OnShutdown();
110 } 111 }
111 112
112 // static 113 // static
113 void ArcServiceManager::SetArcBridgeServiceForTesting( 114 void ArcServiceManager::SetArcBridgeServiceForTesting(
114 std::unique_ptr<ArcBridgeService> arc_bridge_service) { 115 std::unique_ptr<ArcBridgeService> arc_bridge_service) {
115 if (g_arc_bridge_service_for_testing) { 116 if (g_arc_bridge_service_for_testing) {
116 delete g_arc_bridge_service_for_testing; 117 delete g_arc_bridge_service_for_testing;
117 } 118 }
118 g_arc_bridge_service_for_testing = arc_bridge_service.release(); 119 g_arc_bridge_service_for_testing = arc_bridge_service.release();
119 } 120 }
120 121
121 } // namespace arc 122 } // namespace arc
OLDNEW
« no previous file with comments | « components/arc/arc_bridge_service_unittest.cc ('k') | components/arc/arc_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698