Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Side by Side Diff: components/arc/arc_bridge_service_impl.cc

Issue 2436763004: More graceful shutdown for ArcSession. (Closed)
Patch Set: Add StopArcInstance Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/arc/arc_bridge_service_impl.h ('k') | components/arc/arc_bridge_service_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/arc_bridge_service_impl.h" 5 #include "components/arc/arc_bridge_service_impl.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 10 matching lines...) Expand all
21 #include "components/prefs/pref_service.h" 21 #include "components/prefs/pref_service.h"
22 22
23 namespace arc { 23 namespace arc {
24 24
25 extern ArcBridgeService* g_arc_bridge_service; 25 extern ArcBridgeService* g_arc_bridge_service;
26 26
27 namespace { 27 namespace {
28 constexpr int64_t kReconnectDelayInSeconds = 5; 28 constexpr int64_t kReconnectDelayInSeconds = 5;
29 } // namespace 29 } // namespace
30 30
31 ArcBridgeServiceImpl::ArcBridgeServiceImpl() 31 ArcBridgeServiceImpl::ArcBridgeServiceImpl(
32 const scoped_refptr<base::TaskRunner>& blocking_task_runner)
32 : session_started_(false), 33 : session_started_(false),
33 factory_(base::Bind(ArcSession::Create)), 34 factory_(base::Bind(ArcSession::Create, blocking_task_runner)),
34 weak_factory_(this) { 35 weak_factory_(this) {
35 DCHECK(!g_arc_bridge_service); 36 DCHECK(!g_arc_bridge_service);
36 g_arc_bridge_service = this; 37 g_arc_bridge_service = this;
37 } 38 }
38 39
39 ArcBridgeServiceImpl::~ArcBridgeServiceImpl() { 40 ArcBridgeServiceImpl::~ArcBridgeServiceImpl() {
40 if (arc_session_) 41 if (arc_session_)
41 arc_session_->RemoveObserver(this); 42 arc_session_->RemoveObserver(this);
42 43
43 DCHECK(g_arc_bridge_service == this); 44 DCHECK(g_arc_bridge_service == this);
44 g_arc_bridge_service = nullptr; 45 g_arc_bridge_service = nullptr;
45 } 46 }
46 47
47 void ArcBridgeServiceImpl::HandleStartup() { 48 void ArcBridgeServiceImpl::RequestStart() {
48 DCHECK(CalledOnValidThread()); 49 DCHECK(CalledOnValidThread());
49 if (session_started_) 50 if (session_started_)
50 return; 51 return;
51 VLOG(1) << "Session started"; 52 VLOG(1) << "Session started";
52 session_started_ = true; 53 session_started_ = true;
53 PrerequisitesChanged(); 54 PrerequisitesChanged();
54 } 55 }
55 56
56 void ArcBridgeServiceImpl::Shutdown() { 57 void ArcBridgeServiceImpl::RequestStop() {
57 DCHECK(CalledOnValidThread()); 58 DCHECK(CalledOnValidThread());
58 if (!session_started_) 59 if (!session_started_)
59 return; 60 return;
60 VLOG(1) << "Session ended"; 61 VLOG(1) << "Session ended";
61 session_started_ = false; 62 session_started_ = false;
62 PrerequisitesChanged(); 63 PrerequisitesChanged();
63 } 64 }
64 65
66 void ArcBridgeServiceImpl::OnShutdown() {
67 DCHECK(CalledOnValidThread());
68 VLOG(1) << "OnShutdown";
69 if (!session_started_)
70 return;
71 session_started_ = false;
72 reconnect_ = false;
73 if (arc_session_)
74 arc_session_->OnShutdown();
75 }
76
65 void ArcBridgeServiceImpl::SetArcSessionFactoryForTesting( 77 void ArcBridgeServiceImpl::SetArcSessionFactoryForTesting(
66 const ArcSessionFactory& factory) { 78 const ArcSessionFactory& factory) {
67 DCHECK(!factory.is_null()); 79 DCHECK(!factory.is_null());
68 factory_ = factory; 80 factory_ = factory;
69 } 81 }
70 82
71
72 void ArcBridgeServiceImpl::DisableReconnectDelayForTesting() { 83 void ArcBridgeServiceImpl::DisableReconnectDelayForTesting() {
73 use_delay_before_reconnecting_ = false; 84 use_delay_before_reconnecting_ = false;
74 } 85 }
75 86
76 void ArcBridgeServiceImpl::PrerequisitesChanged() { 87 void ArcBridgeServiceImpl::PrerequisitesChanged() {
77 DCHECK(CalledOnValidThread()); 88 DCHECK(CalledOnValidThread());
78 VLOG(1) << "Prerequisites changed. " 89 VLOG(1) << "Prerequisites changed. "
79 << "state=" << static_cast<uint32_t>(state()) 90 << "state=" << static_cast<uint32_t>(state())
80 << ", session_started=" << session_started_; 91 << ", session_started=" << session_started_;
81 if (state() == State::STOPPED) { 92 if (state() == State::STOPPED) {
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 weak_factory_.GetWeakPtr()), 164 weak_factory_.GetWeakPtr()),
154 base::TimeDelta::FromSeconds(kReconnectDelayInSeconds)); 165 base::TimeDelta::FromSeconds(kReconnectDelayInSeconds));
155 } else { 166 } else {
156 // Restart immediately. 167 // Restart immediately.
157 PrerequisitesChanged(); 168 PrerequisitesChanged();
158 } 169 }
159 } 170 }
160 } 171 }
161 172
162 } // namespace arc 173 } // namespace arc
OLDNEW
« no previous file with comments | « components/arc/arc_bridge_service_impl.h ('k') | components/arc/arc_bridge_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698