DevTools: Flesh out AccessibilityModel and use SDK objects instead of protocol objects

DevTools: Flesh out AccessibilityModel and use SDK objects instead of protocol objects

BUG=

Committed: https://crrev.com/e61bdf477cf5cb0e2d8028a54118a0e9fdc3f6ad
Cr-Commit-Position: refs/heads/master@{#426537}

[aboxhall, 2016-10-19 20:43:06]

aboxhall@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-10-19 21:41:29]

Nice one!

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
(right):

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:25:
this._role = payload.role;
I'd instead do
this._role = payload.role || null;
This makes this._role always present, and eliminates the need for "|| null" in
getter.

Same goes for all other properties.

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:74:
if (!("_" + propertyName in this))
Don't do this. Access properties explicitly:

if (this._name)
  properties.push({name: "name", value: this._name});

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:106:
* @return {?Array<!AccessibilityAgent.AXProperty>}
Are you going to convert AXProperty to WebInspector.Something as well?

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:155:
setAXNodeForAXId: function(axId, axNode)
You can make this _setAXNodeForAXId, it can be called in this file by other
classes.

[aboxhall, 2016-10-19 22:46:23]

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
(right):

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:25:
this._role = payload.role;
On 2016/10/19 21:41:29, dgozman wrote:
> I'd instead do
> this._role = payload.role || null;
> This makes this._role always present, and eliminates the need for "|| null" in
> getter.
> 
> Same goes for all other properties.

Done.

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:74:
if (!("_" + propertyName in this))
On 2016/10/19 21:41:29, dgozman wrote:
> Don't do this. Access properties explicitly:
> 
> if (this._name)
>   properties.push({name: "name", value: this._name});

Done.

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:106:
* @return {?Array<!AccessibilityAgent.AXProperty>}
On 2016/10/19 21:41:28, dgozman wrote:
> Are you going to convert AXProperty to WebInspector.Something as well?

Hm, should probably do that at some point, yeah.

https://codereview.chromium.org/2436703003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:155:
setAXNodeForAXId: function(axId, axNode)
On 2016/10/19 21:41:28, dgozman wrote:
> You can make this _setAXNodeForAXId, it can be called in this file by other
> classes.

Done.

[dgozman, 2016-10-19 22:55:01]

lgtm

[aboxhall, 2016-10-19 23:19:45]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:20:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 00:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 00:56:24]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aboxhall, 2016-10-20 16:36:31]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2016-10-20 16:36:32]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2436703003/#ps80001
(title: "Update edit-aria-attributes to operate on SDK object")

[commit-bot: I haz the power, 2016-10-20 16:37:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:29:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:20:26]

Description was changed from

==========
DevTools: Flesh out AccessibilityModel and use SDK objects instead of protocol
objects

BUG=
==========

to

==========
DevTools: Flesh out AccessibilityModel and use SDK objects instead of protocol
objects

BUG=

Committed: https://crrev.com/e61bdf477cf5cb0e2d8028a54118a0e9fdc3f6ad
Cr-Commit-Position: refs/heads/master@{#426537}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:27]

Patchset 5 (id:??) landed as
https://crrev.com/e61bdf477cf5cb0e2d8028a54118a0e9fdc3f6ad
Cr-Commit-Position: refs/heads/master@{#426537}