Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2436613002: [debugger] Remove unused arg from setPauseOnExceptionsImpl (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
kozy, Yang
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Remove unused arg from setPauseOnExceptionsImpl BUG=v8:5530 Committed: https://crrev.com/ae64bdce4eabc2dbb967a535f5dfd7310f6483e8 Cr-Commit-Position: refs/heads/master@{#40425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/inspector/v8-debugger-agent-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 2 months ago (2016-10-19 09:06:11 UTC) #6
Yang
On 2016/10/19 09:06:11, jgruber wrote: lgtm.
4 years, 2 months ago (2016-10-19 09:10:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436613002/1
4 years, 2 months ago (2016-10-19 09:28:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 10:24:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae64bdce4eabc2dbb967a535f5dfd7310f6483e8
Cr-Commit-Position: refs/heads/master@{#40425}

Powered by Google App Engine
This is Rietveld 408576698