Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2436563003: Expose setSequentialFocusNavigationStartingPoint to accessibility. (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
Mike West, aboxhall
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, haraken, je_julie, kinuko+watch, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose setSequentialFocusNavigationStartingPoint to accessibility. This is useful so that a screen reader user can jump to a particular non-focusable node (like a heading) and then press Tab to get the next focusable element immediately following that one. BUG=655272 Committed: https://crrev.com/a4000efa7082ab9f6a6ed6cf39493a27096d0d59 Cr-Commit-Position: refs/heads/master@{#426633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
dmazzoni
4 years, 2 months ago (2016-10-19 23:24:54 UTC) #3
aboxhall
Happy to see this!
4 years, 2 months ago (2016-10-19 23:29:58 UTC) #6
Mike West
LGTM.
4 years, 2 months ago (2016-10-20 09:32:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436563003/1
4 years, 2 months ago (2016-10-20 22:50:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 23:04:07 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:24:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4000efa7082ab9f6a6ed6cf39493a27096d0d59
Cr-Commit-Position: refs/heads/master@{#426633}

Powered by Google App Engine
This is Rietveld 408576698