[Reland] Make PaymentOption store a Drawable instead of id

[Reland] Make PaymentOption store a Drawable instead of id

Make PaymentOption store a Drawable instead of id for the icon.
This will allow to use icons not contained in the default resources.

Original patch http://crrev.com/2436883002 from rob.buis@samsung.com.

BUG=620173
Committed: https://crrev.com/d9a3d9a30d61dcba7ef4b489606cabba7ced9050
Cr-Commit-Position: refs/heads/master@{#426843}

[please use gerrit instead, 2016-10-21 15:53:03]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 15:53:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-10-21 15:58:39]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-10-21 15:58:49]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2016-10-21 15:59:36]

rouslan@chromium.org changed reviewers:
+ dskiba@chromium.org, rob.buis@samsung.com

[please use gerrit instead, 2016-10-21 15:59:37]

rob.buis@ or dskiba@, ptal.

[please use gerrit instead, 2016-10-21 15:59:40]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 16:00:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rwlbuis, 2016-10-21 16:04:08]

On 2016/10/21 15:59:37, rouslan wrote:
> rob.buis@ or dskiba@, ptal.

What changed compared to my patch? Is an assert removed? A Drawable made
nullable?

[rwlbuis, 2016-10-21 16:06:46]

https://codereview.chromium.org/2436363002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
(right):

https://codereview.chromium.org/2436363002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java:98:
* @param icon          The drawable icon identifier or null.
I guess "icon identifier" is not the right term anymore (I realised this only
after landing).

[please use gerrit instead, 2016-10-21 16:06:57]

On 2016/10/21 16:04:08, rwlbuis wrote:
> What changed compared to my patch?

The most important change is passing the context to the
PaymentAppFactoryAddition.create(). This lets Chrome's internal integration with
Android Pay to switch from using an integer resource ID to a Drawable object.

There were a few cosmetic changes in comments as well. For example, one comment
stated with "/** * Stuff...". I removed the 3rd "*", because it's not necessary
in there.

[please use gerrit instead, 2016-10-21 16:08:35]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 16:08:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-10-21 16:08:54]

https://codereview.chromium.org/2436363002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
(right):

https://codereview.chromium.org/2436363002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java:98:
* @param icon          The drawable icon identifier or null.
On 2016/10/21 16:06:46, rwlbuis wrote:
> I guess "icon identifier" is not the right term anymore (I realised this only
> after landing).

Done.

[rwlbuis, 2016-10-21 16:10:29]

lgtm

[please use gerrit instead, 2016-10-21 16:10:49]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2016-10-21 16:11:00]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:11:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 16:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:54:22]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[please use gerrit instead, 2016-10-21 17:12:30]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-10-21 17:12:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rob.buis@samsung.com
Link to the patchset: https://codereview.chromium.org/2436363002/#ps80001
(title: "Fix integraiton test")

[commit-bot: I haz the power, 2016-10-21 17:12:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 18:11:20]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-21 18:42:31]

Description was changed from

==========
[Reland] Make PaymentOption store a Drawable instead of id

Make PaymentOption store a Drawable instead of id for the icon.
This will allow to use icons not contained in the default resources.

Original patch http://crrev.com/2436883002 from rob.buis@samsung.com.

BUG=620173
==========

to

==========
[Reland] Make PaymentOption store a Drawable instead of id

Make PaymentOption store a Drawable instead of id for the icon.
This will allow to use icons not contained in the default resources.

Original patch http://crrev.com/2436883002 from rob.buis@samsung.com.

BUG=620173

Committed: https://crrev.com/d9a3d9a30d61dcba7ef4b489606cabba7ced9050
Cr-Commit-Position: refs/heads/master@{#426843}
==========

[commit-bot: I haz the power, 2016-10-21 18:42:32]

Patchset 3 (id:??) landed as
https://crrev.com/d9a3d9a30d61dcba7ef4b489606cabba7ced9050
Cr-Commit-Position: refs/heads/master@{#426843}