Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2436323002: MD History: Remove paper-checkbox from lazy loaded element bundle (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove paper-checkbox from lazy loaded element bundle This element is no longer used, and was included in this file by mistake. Removing it reduces the size of the element bundle by about 7KB. BUG=425625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8a9b43fb69ae9e0ad04fa0d51a6148e343ae56a4 Cr-Commit-Position: refs/heads/master@{#426829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -180 lines) Patch
M chrome/browser/resources/md_history/lazy_load.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 chunk +0 lines, -178 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tsergeant
whoops
4 years, 2 months ago (2016-10-21 15:15:36 UTC) #4
calamity
lgtm
4 years, 2 months ago (2016-10-21 16:46:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436323002/1
4 years, 2 months ago (2016-10-21 17:12:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 17:34:00 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 17:36:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a9b43fb69ae9e0ad04fa0d51a6148e343ae56a4
Cr-Commit-Position: refs/heads/master@{#426829}

Powered by Google App Engine
This is Rietveld 408576698