Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2436123002: Fix CFI errors in Oilpan (Closed)

Created:
4 years, 2 months ago by haraken
Modified:
4 years, 2 months ago
Reviewers:
keishi, pcc1
CC:
chromium-reviews, blink-reviews, haraken, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix CFI errors in Oilpan Oilpan is currently casting an object to a polymorphic type to check if the object has a vtable or not, but this causes a CFI error if the object doesn't have the polymorphic type. This CL fixes the issue, follwing the krasin's advice on the bug. BUG=601193 Committed: https://crrev.com/71b71dabac9102c1f2d48040ca15ca288803571f Cr-Commit-Position: refs/heads/master@{#426615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
haraken
PTAL
4 years, 2 months ago (2016-10-20 17:46:39 UTC) #2
krasin1
On 2016/10/20 17:46:39, haraken wrote: > PTAL Sorry, I am on vacation this week. I ...
4 years, 2 months ago (2016-10-20 18:07:20 UTC) #5
pcc1
LGTM
4 years, 2 months ago (2016-10-20 20:12:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436123002/1
4 years, 2 months ago (2016-10-20 20:32:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 22:11:34 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71b71dabac9102c1f2d48040ca15ca288803571f
Cr-Commit-Position: refs/heads/master@{#426615}

Powered by Google App Engine
This is Rietveld 408576698