Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2436023003: Adds CaptureClientObserver as a way to track changes in capture (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds CaptureClientObserver as a way to track changes in capture I'm going to need this for the aura-mus work so that what is the WindowTreeClient implementation can track capture and update the server appropriately. I didn't update the desktop client as I don't think I'll need that one. BUG=none TEST=none R=sadrul@chromium.org Committed: https://crrev.com/946eb204231b1edae4320dd9ee1e3a3ee9cf6767 Cr-Commit-Position: refs/heads/master@{#426848}

Patch Set 1 #

Patch Set 2 : remove other change #

Patch Set 3 : fix desktop #

Total comments: 2

Patch Set 4 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -15 lines) Patch
M ash/display/mirror_window_controller.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/client/capture_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
A ui/aura/client/capture_client_observer.h View 1 chunk +28 lines, -0 lines 0 comments Download
M ui/aura/client/default_capture_client.h View 3 chunks +6 lines, -3 lines 0 comments Download
M ui/aura/client/default_capture_client.cc View 1 3 chunks +17 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_capture_client.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_capture_client.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M ui/wm/core/capture_controller.h View 3 chunks +5 lines, -1 line 0 comments Download
M ui/wm/core/capture_controller.cc View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sky
4 years, 2 months ago (2016-10-21 14:45:51 UTC) #1
sadrul
lgtm https://codereview.chromium.org/2436023003/diff/40001/ash/display/mirror_window_controller.cc File ash/display/mirror_window_controller.cc (right): https://codereview.chromium.org/2436023003/diff/40001/ash/display/mirror_window_controller.cc#newcode109 ash/display/mirror_window_controller.cc:109: // Returns the current capture window. It's weird ...
4 years, 1 month ago (2016-10-21 16:58:56 UTC) #8
sky
https://codereview.chromium.org/2436023003/diff/40001/ash/display/mirror_window_controller.cc File ash/display/mirror_window_controller.cc (right): https://codereview.chromium.org/2436023003/diff/40001/ash/display/mirror_window_controller.cc#newcode109 ash/display/mirror_window_controller.cc:109: // Returns the current capture window. On 2016/10/21 16:58:56, ...
4 years, 1 month ago (2016-10-21 16:59:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436023003/60001
4 years, 1 month ago (2016-10-21 17:02:08 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-21 18:26:00 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 18:42:40 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/946eb204231b1edae4320dd9ee1e3a3ee9cf6767
Cr-Commit-Position: refs/heads/master@{#426848}

Powered by Google App Engine
This is Rietveld 408576698