[Findit] Asynchronously process flake reports from chromium-try-flakes.

[Findit] Asynchronously process flake reports from chromium-try-flakes.

Since a hacky solution was implemented to map a CQ trybot step to a Waterfall buildbot step, multiple http requests have to be sent to Swarming and Isolate Server to retrieve step metadata and test output. Such http requests could lead to long processing time for a single flake report, and cause timeout on chromium-try-flakes side.

This CL is to put flake reports from chromium-try-flakes in a task queue, and then process them asynchronously.

BUG=656138
Committed: https://chromium.googlesource.com/infra/infra/+/e9f14cc4676df7495e28f583d2bffe383159d267

[stgao, 2016-10-20 17:42:48]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[stgao, 2016-10-20 17:42:49]

ptal

[stgao, 2016-10-20 17:45:55]

Description was changed from

==========
[Findit] Asynchronously process flake reports from chromium-try-flakes.

BUG=656138
==========

to

==========
[Findit] Asynchronously process flake reports from chromium-try-flakes.

Since a hacky solution was implemented to map a CQ trybot step to a Waterfall
buildbot step, multiple http requests have to be sent to Swarming and Isolate
Server to retrieve step metadata and test output. Such http requests could lead
to long processing time for a single flake report, and cause timeout on
chromium-try-flakes side.

This CL is to put flake reports from chromium-try-flakes in a task queue, and
then process them asynchronously.

BUG=656138
==========

[chanli, 2016-10-21 06:08:12]

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
File appengine/findit/test/findit_api_test.py (right):

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
appengine/findit/test/findit_api_test.py:758: self.assertEqual(1,
mocked_func.call_count)
Sorry if this is a stupid question, but if the request failed to be queued,
shouldn't there be some side effect of request not being queued? Or
chromium-try-flakes will handle it?

[stgao, 2016-10-21 14:03:11]

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
File appengine/findit/test/findit_api_test.py (right):

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
appengine/findit/test/findit_api_test.py:758: self.assertEqual(1,
mocked_func.call_count)
On 2016/10/21 06:08:12, chanli wrote:
> Sorry if this is a stupid question, but if the request failed to be queued,
> shouldn't there be some side effect of request not being queued? Or
> chromium-try-flakes will handle it?

Currently, we just drop the request if we fail to queue it. (That should be very
rare. For waterfall, such case happened only once since the queue approach was
in place.)

What side effect do you refer to? Chromium-try-flakes  does retry upon failure.
Maybe we could throw the exception instead of muting it.

+sergiyb what do you think?

[stgao, 2016-10-21 14:44:35]

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
File appengine/findit/test/findit_api_test.py (right):

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
appengine/findit/test/findit_api_test.py:5: import datetime
todo: remove

[lijeffrey, 2016-10-21 15:31:22]

lgtm

[stgao, 2016-10-21 22:25:16]

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
File appengine/findit/test/findit_api_test.py (right):

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
appengine/findit/test/findit_api_test.py:5: import datetime
On 2016/10/21 14:44:35, stgao wrote:
> todo: remove

Done.

https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
appengine/findit/test/findit_api_test.py:758: self.assertEqual(1,
mocked_func.call_count)
On 2016/10/21 06:08:12, chanli wrote:
> Sorry if this is a stupid question, but if the request failed to be queued,
> shouldn't there be some side effect of request not being queued? Or
> chromium-try-flakes will handle it?

Done.

[chanli, 2016-10-21 22:52:50]

On 2016/10/21 22:25:16, stgao wrote:
>
https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
> File appengine/findit/test/findit_api_test.py (right):
> 
>
https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
> appengine/findit/test/findit_api_test.py:5: import datetime
> On 2016/10/21 14:44:35, stgao wrote:
> > todo: remove
> 
> Done.
> 
>
https://codereview.chromium.org/2435983003/diff/40001/appengine/findit/test/f...
> appengine/findit/test/findit_api_test.py:758: self.assertEqual(1,
> mocked_func.call_count)
> On 2016/10/21 06:08:12, chanli wrote:
> > Sorry if this is a stupid question, but if the request failed to be queued,
> > shouldn't there be some side effect of request not being queued? Or
> > chromium-try-flakes will handle it?
> 
> Done.

lgtm

[stgao, 2016-10-21 22:53:23]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-10-21 22:53:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2435983003/#ps60001
(title: "fix nit.")

[commit-bot: I haz the power, 2016-10-21 22:53:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:56:02]

Try jobs failed on following builders:
  Infra Linux Precise 32 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/320244b443888b10)
  Infra Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/320244b4221fac10)

[stgao, 2016-10-21 23:48:34]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-10-21 23:48:35]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org,
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2435983003/#ps80001
(title: "Rebase to resolve conflict")

[commit-bot: I haz the power, 2016-10-21 23:48:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 00:03:24]

Description was changed from

==========
[Findit] Asynchronously process flake reports from chromium-try-flakes.

Since a hacky solution was implemented to map a CQ trybot step to a Waterfall
buildbot step, multiple http requests have to be sent to Swarming and Isolate
Server to retrieve step metadata and test output. Such http requests could lead
to long processing time for a single flake report, and cause timeout on
chromium-try-flakes side.

This CL is to put flake reports from chromium-try-flakes in a task queue, and
then process them asynchronously.

BUG=656138
==========

to

==========
[Findit] Asynchronously process flake reports from chromium-try-flakes.

Since a hacky solution was implemented to map a CQ trybot step to a Waterfall
buildbot step, multiple http requests have to be sent to Swarming and Isolate
Server to retrieve step metadata and test output. Such http requests could lead
to long processing time for a single flake report, and cause timeout on
chromium-try-flakes side.

This CL is to put flake reports from chromium-try-flakes in a task queue, and
then process them asynchronously.

BUG=656138

Committed:
https://chromium.googlesource.com/infra/infra/+/e9f14cc4676df7495e28f583d2bff...
==========

[commit-bot: I haz the power, 2016-10-22 00:03:29]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/e9f14cc4676df7495e28f583d2bff...