third_party/WebKit/Source/bindings/scripts/utilities.py - Issue 2435973003: [Bindings][Refactoring] Make binding scripts use utilities to handle pickle files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/utilities.py

Issue 2435973003: [Bindings][Refactoring] Make binding scripts use utilities to handle pickle files (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/utilities.py

diff --git a/third_party/WebKit/Source/bindings/scripts/utilities.py b/third_party/WebKit/Source/bindings/scripts/utilities.py

index a06ff244e0d5792ce50af0e980ce6edf71719d25..a212453fd4d81227c3bd6801b79e64054a153a52 100644

--- a/third_party/WebKit/Source/bindings/scripts/utilities.py

+++ b/third_party/WebKit/Source/bindings/scripts/utilities.py

@@ -299,8 +299,12 @@ def read_idl_files_list_from_file(filename, is_gyp_format):

def read_pickle_files(pickle_filenames):

for pickle_filename in pickle_filenames:

- with open(pickle_filename) as pickle_file:

- yield pickle.load(pickle_file)

+ yield read_pickle_file(pickle_filename)

+def read_pickle_file(pickle_filename):

+ with open(pickle_filename) as pickle_file:

+ return pickle.load(pickle_file)

def write_file(new_text, destination_filename):

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/idl_compiler.py ('k') | no next file » | no next file with comments »