Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2435863004: Remove stl_util's deletion function use from content/. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, asanka, tzik, posciak+watch_chromium.org, rginda+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, iclelland+watch_chromium.org, jam, chasej+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, nhiroki, feature-media-reviews_chromium.org, piman+watch_chromium.org, mlamouri+watch-manifest_chromium.org, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, dtapuska+chromiumwatch_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion function use from content/. BUG=555865 Committed: https://crrev.com/cebda79248867b1ae529fdfab8b46842c029c729 Cr-Commit-Position: refs/heads/master@{#426832}

Patch Set 1 #

Patch Set 2 : minus service worker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -223 lines) Patch
M content/browser/appcache/appcache_backend_impl.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_backend_impl.cc View 4 chunks +10 lines, -20 lines 0 comments Download
M content/browser/appcache/appcache_service_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_service_impl.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M content/browser/background_sync/background_sync_context.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_context.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/tethering_handler.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 14 chunks +23 lines, -27 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/download/save_file_manager.h View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/download/save_file_manager.cc View 8 chunks +15 lines, -18 lines 0 comments Download
M content/browser/download/save_package.h View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/download/save_package.cc View 13 chunks +33 lines, -28 lines 0 comments Download
M content/browser/manifest/manifest_manager_host.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/manifest/manifest_manager_host.cc View 5 chunks +6 lines, -12 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 8 chunks +12 lines, -10 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 4 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Avi (use Gerrit)
Pan-content removal...
4 years, 2 months ago (2016-10-20 17:38:06 UTC) #10
jam
lgtm
4 years, 2 months ago (2016-10-21 15:56:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435863004/20001
4 years, 2 months ago (2016-10-21 16:21:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 17:38:30 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 17:41:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cebda79248867b1ae529fdfab8b46842c029c729
Cr-Commit-Position: refs/heads/master@{#426832}

Powered by Google App Engine
This is Rietveld 408576698