Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

Issue 2435843002: Remove UMA collection no longer needed. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
index 1c56b46feb8850330ac0d8f3435578e70bc0a099..88ddb3606c54a3768827f2300345fcedd8613735 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
@@ -59,20 +59,6 @@ void JavaScriptDialogTabHelper::RunJavaScriptDialog(
SiteEngagementService* site_engagement_service = SiteEngagementService::Get(
Profile::FromBrowserContext(alerting_web_contents->GetBrowserContext()));
double engagement_score = site_engagement_service->GetScore(origin_url);
- switch (message_type) {
- case content::JAVASCRIPT_MESSAGE_TYPE_ALERT:
- UMA_HISTOGRAM_PERCENTAGE("JSDialogs.SiteEngagementOfDialogs.Alert",
- engagement_score);
- break;
- case content::JAVASCRIPT_MESSAGE_TYPE_CONFIRM:
- UMA_HISTOGRAM_PERCENTAGE("JSDialogs.SiteEngagementOfDialogs.Confirm",
- engagement_score);
- break;
- case content::JAVASCRIPT_MESSAGE_TYPE_PROMPT:
- UMA_HISTOGRAM_PERCENTAGE("JSDialogs.SiteEngagementOfDialogs.Prompt",
- engagement_score);
- break;
- }
int32_t message_length = static_cast<int32_t>(message_text.length());
if (engagement_score == 0) {
UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementNone",
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698