Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2435833002: [Cast,Android,PresentationAPI] Don't consider connecting GoogleApiClient as valid. (Closed)

Created:
4 years, 2 months ago by whywhat
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast,Android,PresentationAPI] Don't consider connecting GoogleApiClient as valid. Seems like when GoogleApiClient is in connecting state, the Cast APIs don't work. BUG=651780 TEST=https://storage.googleapis.com/castapi/CastHelloVideo/index.html Committed: https://crrev.com/f4190f0e7e6979c5012c77b1c1213b9b43edab86 Cr-Commit-Position: refs/heads/master@{#426274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
whywhat
PTaL
4 years, 2 months ago (2016-10-19 18:37:00 UTC) #2
Zhiqiang Zhang (Slow)
lgtm
4 years, 2 months ago (2016-10-19 19:03:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435833002/1
4 years, 2 months ago (2016-10-19 20:27:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 20:49:12 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 13:11:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4190f0e7e6979c5012c77b1c1213b9b43edab86
Cr-Commit-Position: refs/heads/master@{#426274}

Powered by Google App Engine
This is Rietveld 408576698