[V8][asm.js] Adds support to global const variables.

test/cctest/asmjs/test-asm-typer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstring>
 #include <functional>
 #include <iostream>
 #include <memory>
 
 #include "src/asmjs/asm-typer.h"
@@ skipping 487 matching lines @@
     }
   }
 }
 
 TEST(ErrorsInGlobalVariableDefinition) {
   const struct {
     const char* decl;
     const char* error_message;
   } kTests[] = {
       {"var v;", "Global variable missing initializer"},
-      {"var v = uninitialized;", "Invalid global variable initializer"},
+      {"var v = uninitialized;", "Undeclared identifier in global"},
       {"var v = 'use asm';", "type annotation - forbidden literal"},
       {"var v = 4294967296;", " - forbidden literal"},
-      {"var v = not_fround;", "Invalid global variable initializer"},
+      {"var v = not_fround;", "initialize a global must be a const"},
       {"var v = not_fround(1);", "expected call fround(literal)"},
       {"var v = __fround__(1.0);", "expected call fround(literal)"},
       {"var v = fround(1.0, 1.0);", "expected call fround(literal)"},
       {"var v = fround(not_fround);", "literal argument for call to fround"},
+      {"var v = i?0:1;", "Invalid global variable initializer"},
       {"var v = stdlib.nan", "Invalid import"},
       {"var v = stdlib.Math.nan", "Invalid import"},
       {"var v = stdlib.Mathh.E", "Invalid import"},
       {"var v = stdlib.Math", "Invalid import"},
       {"var v = Stdlib.Math.E", "Invalid import"},
       {"var v = stdlib.Math.E[0]", "Invalid import"},
       {"var v = stdlibb.NaN", "Invalid import"},
       {"var v = ffi.NaN[0]", "Invalid import"},
       {"var v = heap.NaN[0]", "Invalid import"},
       {"var v = ffi.foo * 2.0;", "unrecognized annotation"},
@@ skipping 255 matching lines @@
        "  var c = 0; var c = 1.0;\n"
        "}\n",
        "Redeclared local"},
       {"function f(b, a) {\n"
        "  b = +b;\n"
        "  a = a|0;\n"
        "  f();\n"
        "  var c = 0;\n"
        "}\n",
        "Local variable missing initializer in asm.js module"},
+      {"function f(a) {\n"
+       "  a = a|0;\n"
+       "  var x = a;\n"
+       "}\n",
+       "variable declaration initializer must be const"},
+      {"function f() {\n"
+       "  var x = 1+i;\n"
+       "}\n",
+       "should be a literal, const, or fround(literal"},
+      {"function f() {\n"
+       "  var x = a;\n"
+       "}\n",
+       "Undeclared identifier in variable declaration initializer"},
       {"function f() {\n"
        "  function ff() {}\n"
        "}\n",
        "Functions may only define inner variables"},
       {"function f() {\n"
        "  return a+1;\n"
        "}\n",
        "Invalid return type annotation"},
       {"function f() {\n"
        "  return ~~x;\n"
        "}\n",
        "Invalid return type annotation"},
       {"function f() {\n"
        "  return d();\n"
        "}\n",
        "Invalid function call in return statement"},
       {"function f() {\n"
        "  return 'use asm';\n"
        "}\n",
        "Invalid literal in return statement"},
       {"function f() {\n"
        " return 2147483648;\n"
        "}\n",
        "Invalid literal in return statement"},
+      {"function f(a) {\n"
+       "  a = a|0;\n"
+       "  return a;\n"
+       "}\n",
+       "in return statement is not const"},
+      {"function f() {\n"
+       "  return a;\n"
+       "}\n",
+       "Undeclared identifier in return statement"},
+      {"function f() {\n"
+       "  return i?0:1;\n"
+       "}\n",
+       "Invalid return type expression"},
       {"function f() {\n"
        "  return stdlib.Math.E;"
        "}\n",
        "Invalid return type expression"},
       {"function f() {\n"
        "  return E[0];"
        "}\n",
        "Invalid return type expression"},
       {"function I() {}\n", "Identifier redefined as function"},
       {"function foo() {}\n", "Identifier redefined as function"},
@@ skipping 1167 matching lines @@
   for (size_t ii = 0; ii < arraysize(kTests); ++ii) {
     if (!ValidationOf(Module(kTests[ii]))
              ->FailsWithMessage("Can't assign to immutable symbol")) {
       std::cerr << "Test:\n" << kTests[ii];
       CHECK(false);
     }
   }
 }
 
 }  // namespace