Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2435753002: Revert of Generate Signed Distance Field directly from vector path (Closed)

Created:
4 years, 2 months ago by dogben
Modified:
4 years, 2 months ago
CC:
reviews_skia.org, developer_arm.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Generate Signed Distance Field directly from vector path (patchset #18 id:340001 of https://chromiumcodereview.appspot.com/1643143002/ ) Reason for revert: Multiple assertion failures on multiple platforms: ../../../src/gpu/GrDistanceFieldGenFromVector.cpp:806: fatal error: "assert(((col != width - 1) || (windingNumber == 0)) && "Winding number should be zero at the end of a scan line.")" https://luci-milo.appspot.com/swarming/task/31f5353caf8cc410 https://luci-milo.appspot.com/swarming/task/31f567789cbcec10 c:\b\work\skia\src\pathops\skopangle.cpp:165: fatal error: "assert(lrOpposite != trOpposite)" https://luci-milo.appspot.com/swarming/task/31f570d74f750310 Original issue's description: > Generate Signed Distance Field directly from vector path > > Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 > > Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f > Committed: https://skia.googlesource.com/skia/+/e8f0a7b986f1e5583c9bc162efcdd92fd6430549 TBR=bsalomon@google.com,jvanverth@google.com,mtklein@google.com,wasim.abbas@arm.com,caryclark@google.com,joel.liang@arm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/620ee4f744cefbf2fef60add803816398522baae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -892 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.h View 1 chunk +0 lines, -35 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.cpp View 1 chunk +0 lines, -817 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 4 chunks +29 lines, -27 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.cpp View 2 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dogben
Created Revert of Generate Signed Distance Field directly from vector path
4 years, 2 months ago (2016-10-19 11:42:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435753002/1
4 years, 2 months ago (2016-10-19 11:42:55 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 11:43:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/620ee4f744cefbf2fef60add803816398522baae

Powered by Google App Engine
This is Rietveld 408576698