Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2435723003:
Fix bug for the webgl and angle roll-in tools (Closed)
DescriptionFix bug for the webgl and angle roll-in tools
BUG=657723
Committed: https://crrev.com/aed818075281e5bf3a2f8984f170102cff5e7469
Cr-Commit-Position: refs/heads/master@{#426939}
Patch Set 1 #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== Fix a small bug for the WebGL and Angle Roll-in tools BUG= ========== to ========== Fix a small bug for the WebGL and Angle Roll-in tools BUG= ==========
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, zmo@chromium.org
Description was changed from ========== Fix a small bug for the WebGL and Angle Roll-in tools BUG= ========== to ========== Fix a small bug for the WebGL and Angle Roll-in tools BUG=657723 ==========
yunchao.he@intel.com changed reviewers: + qiankun.miao@intel.com
Description was changed from ========== Fix a small bug for the WebGL and Angle Roll-in tools BUG=657723 ========== to ========== Fix a small bug for the webgl and angle roll-in tools BUG=657723 ==========
Description was changed from ========== Fix a small bug for the webgl and angle roll-in tools BUG=657723 ========== to ========== Fix bug for the webgl and angle roll-in tools BUG=657723 ==========
PTAL. Thanks a lot!
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yunchao.he@intel.com changed reviewers: + geofflang@chromium.org
On 2016/10/20 07:40:27, yunchao wrote: > PTAL. Thanks a lot! Ken, Zhenyao and Geoff, please help to merge this small patch if it is OK. Then we can roll in webgl and angle revisions. Thanks a lot!
On 2016/10/20 08:01:53, yunchao wrote: > On 2016/10/20 07:40:27, yunchao wrote: > > PTAL. Thanks a lot! > > Ken, Zhenyao and Geoff, please help to merge this small patch if it is OK. Then > we can roll in webgl and angle revisions. Thanks a lot! lgtm, but I am not an owner
On 2016/10/20 08:01:53, yunchao wrote: > On 2016/10/20 07:40:27, yunchao wrote: > > PTAL. Thanks a lot! > > Ken, Zhenyao and Geoff, please help to merge this small patch if it is OK. Then > we can roll in webgl and angle revisions. Thanks a lot! lgtm but I am not an owner
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== Fix bug for the webgl and angle roll-in tools BUG=657723 ========== to ========== Fix bug for the webgl and angle roll-in tools BUG=657723 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix bug for the webgl and angle roll-in tools BUG=657723 ========== to ========== Fix bug for the webgl and angle roll-in tools BUG=657723 Committed: https://crrev.com/aed818075281e5bf3a2f8984f170102cff5e7469 Cr-Commit-Position: refs/heads/master@{#426939} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/aed818075281e5bf3a2f8984f170102cff5e7469 Cr-Commit-Position: refs/heads/master@{#426939} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
