Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2435713003: [stubs] KeyedStoreIC: Use BuildFastLoop() helper (Closed)

Created:
4 years, 2 months ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] KeyedStoreIC: Use BuildFastLoop() helper Bonus: CodeStubAssembler::StringIndexOfChar gets the same treatment. Committed: https://crrev.com/03b855410987667c61c32b1c1e90378cdcb68e90 Cr-Commit-Position: refs/heads/master@{#40445}

Patch Set 1 #

Patch Set 2 : StringIndexOfChar too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -80 lines) Patch
M src/code-stub-assembler.cc View 1 4 chunks +64 lines, -80 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jakob Kummerow
Here's the BuildFastLoop() refactoring. I'm not quite sure whether I prefer the old or the ...
4 years, 2 months ago (2016-10-19 14:25:43 UTC) #3
Igor Sheludko
Let's use BuildFastLoop(). lgtm!
4 years, 2 months ago (2016-10-19 15:28:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435713003/20001
4 years, 2 months ago (2016-10-19 15:49:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 16:17:59 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:59 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03b855410987667c61c32b1c1e90378cdcb68e90
Cr-Commit-Position: refs/heads/master@{#40445}

Powered by Google App Engine
This is Rietveld 408576698