Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2676)

Unified Diff: chrome/browser/prerender/prerender_test_utils.cc

Issue 2435693005: Change the final status to APP_TERMINATING on shutdown (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_test_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_test_utils.cc
diff --git a/chrome/browser/prerender/prerender_test_utils.cc b/chrome/browser/prerender/prerender_test_utils.cc
index c3c83a19f2a5bf7594f680971b9b6813e804f83c..36e673d5cede025de7283498711cddd293c2a42b 100644
--- a/chrome/browser/prerender/prerender_test_utils.cc
+++ b/chrome/browser/prerender/prerender_test_utils.cc
@@ -250,23 +250,6 @@ TestPrerenderContents::~TestPrerenderContents() {
EXPECT_EQ(should_be_shown_, was_shown_);
}
-void TestPrerenderContents::RenderProcessGone(base::TerminationStatus status) {
- // On quit, it's possible to end up here when render processes are closed
- // before the PrerenderManager is destroyed. As a result, it's possible to
- // get either FINAL_STATUS_APP_TERMINATING or FINAL_STATUS_RENDERER_CRASHED
- // on quit.
- //
- // It's also possible for this to be called after we've been notified of
- // app termination, but before we've been deleted, which is why the second
- // check is needed.
- if (expected_final_status_ == FINAL_STATUS_APP_TERMINATING &&
- final_status() != expected_final_status_) {
- expected_final_status_ = FINAL_STATUS_RENDERER_CRASHED;
- }
-
- PrerenderContents::RenderProcessGone(status);
-}
-
bool TestPrerenderContents::CheckURL(const GURL& url) {
// Prevent FINAL_STATUS_UNSUPPORTED_SCHEME when navigating to about:crash in
// the PrerenderRendererCrash test.
« no previous file with comments | « chrome/browser/prerender/prerender_test_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698