Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Issue 2435693005: Change the final status to APP_TERMINATING on shutdown (Closed)

Created:
4 years, 2 months ago by pasko
Modified:
4 years, 2 months ago
Reviewers:
mattcary
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the final status to APP_TERMINATING on shutdown This allows simplifying the TestPrerenderContents and makes the FINAL_STATUS_APP_TERMINATING more precise. No new tests are added in this chang, the existing tests cover this path enough IMO. BUG=none Committed: https://crrev.com/339bce6e60caf9dfb38221ed22a004df973ea767 Cr-Commit-Position: refs/heads/master@{#426455}

Patch Set 1 #

Patch Set 2 : remove the shady part from the test #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M chrome/browser/prerender/prerender_contents.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
pasko
4 years, 2 months ago (2016-10-20 09:53:13 UTC) #12
mattcary
lgtm Yay!
4 years, 2 months ago (2016-10-20 09:55:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435693005/40001
4 years, 2 months ago (2016-10-20 12:08:41 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-20 12:14:44 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:17:34 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/339bce6e60caf9dfb38221ed22a004df973ea767
Cr-Commit-Position: refs/heads/master@{#426455}

Powered by Google App Engine
This is Rietveld 408576698