Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: xfa/fwl/core/ifwl_combobox.cpp

Issue 2435603003: Cleanup unused methods and return values in FWL code. (Closed)
Patch Set: Fix typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/ifwl_combobox.h ('k') | xfa/fwl/core/ifwl_combolist.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/ifwl_combobox.cpp
diff --git a/xfa/fwl/core/ifwl_combobox.cpp b/xfa/fwl/core/ifwl_combobox.cpp
index 9d3e58cec6104c265911989ca88039231fbb6a87..edc430a0f24304242879491e301ede471b4993db 100644
--- a/xfa/fwl/core/ifwl_combobox.cpp
+++ b/xfa/fwl/core/ifwl_combobox.cpp
@@ -35,11 +35,6 @@ IFWL_ComboBox::IFWL_ComboBox(const CFWL_WidgetImpProperties& properties)
IFWL_ComboBox::~IFWL_ComboBox() {}
-FWL_Error IFWL_ComboBox::GetClassName(CFX_WideString& wsClass) const {
- wsClass = FWL_CLASS_ComboBox;
- return FWL_Error::Succeeded;
-}
-
FWL_Type IFWL_ComboBox::GetClassID() const {
return FWL_Type::ComboBox;
}
@@ -74,14 +69,14 @@ FWL_Error IFWL_ComboBox::Initialize() {
return FWL_Error::Succeeded;
}
-FWL_Error IFWL_ComboBox::Finalize() {
- if (m_pEdit) {
+void IFWL_ComboBox::Finalize() {
+ if (m_pEdit)
m_pEdit->Finalize();
- }
+
m_pListBox->Finalize();
delete m_pDelegate;
m_pDelegate = nullptr;
- return IFWL_Widget::Finalize();
+ IFWL_Widget::Finalize();
}
FWL_Error IFWL_ComboBox::GetWidgetRect(CFX_RectF& rect, FX_BOOL bAutoSize) {
« no previous file with comments | « xfa/fwl/core/ifwl_combobox.h ('k') | xfa/fwl/core/ifwl_combolist.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698