Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: xfa/fwl/core/ifwl_barcode.cpp

Issue 2435603003: Cleanup unused methods and return values in FWL code. (Closed)
Patch Set: Fix typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/ifwl_barcode.h ('k') | xfa/fwl/core/ifwl_caret.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/ifwl_barcode.cpp
diff --git a/xfa/fwl/core/ifwl_barcode.cpp b/xfa/fwl/core/ifwl_barcode.cpp
index 770a857d784f7016d4c95368fe44163d669d960d..a4b210f1151b14e31b48dab8437e25bd2226ff2a 100644
--- a/xfa/fwl/core/ifwl_barcode.cpp
+++ b/xfa/fwl/core/ifwl_barcode.cpp
@@ -17,11 +17,6 @@ IFWL_Barcode::IFWL_Barcode(const CFWL_WidgetImpProperties& properties)
IFWL_Barcode::~IFWL_Barcode() {}
-FWL_Error IFWL_Barcode::GetClassName(CFX_WideString& wsClass) const {
- wsClass = FWL_CLASS_Barcode;
- return FWL_Error::Succeeded;
-}
-
FWL_Type IFWL_Barcode::GetClassID() const {
return FWL_Type::Barcode;
}
@@ -34,12 +29,14 @@ FWL_Error IFWL_Barcode::Initialize() {
return FWL_Error::Indefinite;
return FWL_Error::Succeeded;
}
-FWL_Error IFWL_Barcode::Finalize() {
+
+void IFWL_Barcode::Finalize() {
delete m_pDelegate;
m_pDelegate = nullptr;
m_pBarcodeEngine.reset();
- return IFWL_Edit::Finalize();
+ IFWL_Edit::Finalize();
}
+
FWL_Error IFWL_Barcode::Update() {
if (IsLocked()) {
return FWL_Error::Indefinite;
@@ -48,6 +45,7 @@ FWL_Error IFWL_Barcode::Update() {
GenerateBarcodeImageCache();
return ret;
}
+
FWL_Error IFWL_Barcode::DrawWidget(CFX_Graphics* pGraphics,
const CFX_Matrix* pMatrix) {
if (!pGraphics)
« no previous file with comments | « xfa/fwl/core/ifwl_barcode.h ('k') | xfa/fwl/core/ifwl_caret.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698