Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: xfa/fwl/core/cfwl_message.h

Issue 2435603003: Cleanup unused methods and return values in FWL code. (Closed)
Patch Set: Fix typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_event.h ('k') | xfa/fwl/core/ifwl_barcode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_message.h
diff --git a/xfa/fwl/core/cfwl_message.h b/xfa/fwl/core/cfwl_message.h
index 2bffff0007c7cbd26c734e47d919d3c9c9cb3ff7..0bfafb5a893dee0e49d0551989b1f2f11cb60ca3 100644
--- a/xfa/fwl/core/cfwl_message.h
+++ b/xfa/fwl/core/cfwl_message.h
@@ -58,7 +58,6 @@ class CFWL_Message {
virtual ~CFWL_Message();
virtual CFWL_Message* Clone();
- virtual FWL_Error GetClassName(CFX_WideString& wsClass) const;
virtual CFWL_MessageType GetClassID() const;
uint32_t Release();
@@ -84,10 +83,6 @@ inline CFWL_Message* CFWL_Message::Clone() {
return nullptr;
}
-inline FWL_Error CFWL_Message::GetClassName(CFX_WideString& wsClass) const {
- return FWL_Error::Succeeded;
-}
-
inline CFWL_MessageType CFWL_Message::GetClassID() const {
return CFWL_MessageType::None;
}
@@ -111,7 +106,6 @@ inline CFWL_Message* CFWL_Message::Retain() {
classname(); \
~classname() override; \
CFWL_Message* Clone() override; \
- FWL_Error GetClassName(CFX_WideString& wsClass) const override; \
CFWL_MessageType GetClassID() const override; \
__VA_ARGS__ \
};
@@ -120,10 +114,6 @@ inline CFWL_Message* CFWL_Message::Retain() {
inline classname::classname() {} \
inline classname::~classname() {} \
inline CFWL_Message* classname::Clone() { return new classname(*this); } \
- inline FWL_Error classname::GetClassName(CFX_WideString& wsClass) const { \
- wsClass = L## #classname; \
- return FWL_Error::Succeeded; \
- } \
inline CFWL_MessageType classname::GetClassID() const { return msgType; } \
__VA_ARGS__
« no previous file with comments | « xfa/fwl/core/cfwl_event.h ('k') | xfa/fwl/core/ifwl_barcode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698