Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1531)

Unified Diff: xfa/fwl/core/cfwl_event.h

Issue 2435603003: Cleanup unused methods and return values in FWL code. (Closed)
Patch Set: Fix typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_event.h
diff --git a/xfa/fwl/core/cfwl_event.h b/xfa/fwl/core/cfwl_event.h
index 3ef81ff3ba6b65e46bc7a24964e03d22e9e77cf5..2e1ed69145b7f3e4aa78baae757d8ac0b8782a62 100644
--- a/xfa/fwl/core/cfwl_event.h
+++ b/xfa/fwl/core/cfwl_event.h
@@ -69,7 +69,6 @@ class CFWL_Event {
CFWL_Event();
virtual ~CFWL_Event();
- virtual FWL_Error GetClassName(CFX_WideString& wsClass) const;
virtual CFWL_EventType GetClassID() const;
uint32_t Release();
@@ -86,10 +85,6 @@ inline CFWL_Event::CFWL_Event()
inline CFWL_Event::~CFWL_Event() {}
-inline FWL_Error CFWL_Event::GetClassName(CFX_WideString& wsClass) const {
- return FWL_Error::Succeeded;
-}
-
inline CFWL_EventType CFWL_Event::GetClassID() const {
return CFWL_EventType::None;
}
@@ -107,16 +102,11 @@ inline uint32_t CFWL_Event::Release() {
public: \
classname(); \
~classname() override; \
- FWL_Error GetClassName(CFX_WideString& wsClass) const override; \
CFWL_EventType GetClassID() const override; \
__VA_ARGS__ \
}; \
inline classname::classname() {} \
inline classname::~classname() {} \
- inline FWL_Error classname::GetClassName(CFX_WideString& wsClass) const { \
- wsClass = L## #classname; \
- return FWL_Error::Succeeded; \
- } \
inline CFWL_EventType classname::GetClassID() const { return eventType; }
FWL_EVENT_DEF(CFWL_EvtMouse, CFWL_EventType::Mouse, FX_FLOAT m_fx;
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698