Cocoa: Fix a constraint violation when navigating away from a detached bookmark bar.

Cocoa: Fix a constraint violation when navigating away from a detached bookmark bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints. DCHECK instead.

BUG=655112
Committed: https://crrev.com/e6144c977967c4ebbf5dedf8706e4ed5aca65124
Cr-Commit-Position: refs/heads/master@{#426944}

[tapted, 2016-10-20 03:53:28]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 03:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-10-20 03:57:30]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 03:57:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 04:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 04:27:19]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-10-20 04:50:12]

Description was changed from

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

BUG=655112
==========

to

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

BUG=655112
==========

[tapted, 2016-10-20 04:50:12]

tapted@chromium.org changed reviewers:
+ mark@chromium.org

[tapted, 2016-10-20 04:54:57]

Description was changed from

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

BUG=655112
==========

to

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints.

BUG=655112
==========

[tapted, 2016-10-20 04:55:43]

Description was changed from

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints.

BUG=655112
==========

to

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints. DCHECK instead.

BUG=655112
==========

[tapted, 2016-10-21 04:51:30]

Hi mark - please take a look (I picked you since you're cc'd on the bug already,
but feel free to bump elsewhere. Per comments on the bug, this was just a red
herring, but the log still gets spammed with or without the fix for the failing
test). - Thanks!

https://codereview.chromium.org/2435593008/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (left):

https://codereview.chromium.org/2435593008/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:985: NSView*
bookmarkBarView = [bookmarkBarController_ view];
confusingly, this was not a `BookmarkBarView*`, but a `BookmarkBarToolbarView*`,
which already has the constraints below in the .xib

[Mark Mentovai, 2016-10-21 16:10:07]

LGTM

[tapted, 2016-10-21 22:46:28]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:47:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 01:20:04]

Description was changed from

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints. DCHECK instead.

BUG=655112
==========

to

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints. DCHECK instead.

BUG=655112
==========

[commit-bot: I haz the power, 2016-10-22 01:20:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-22 01:25:37]

Description was changed from

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints. DCHECK instead.

BUG=655112
==========

to

==========
Cocoa: Fix a constraint violation when navigating away from a detached bookmark
bar.

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints. DCHECK instead.

BUG=655112

Committed: https://crrev.com/e6144c977967c4ebbf5dedf8706e4ed5aca65124
Cr-Commit-Position: refs/heads/master@{#426944}
==========

[commit-bot: I haz the power, 2016-10-22 01:25:38]

Patchset 2 (id:??) landed as
https://crrev.com/e6144c977967c4ebbf5dedf8706e4ed5aca65124
Cr-Commit-Position: refs/heads/master@{#426944}