Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2435593005: [Devtools] Fixed bug with _visibleColumns not set (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 var rootNode = dataGrid.rootNode(); 657 var rootNode = dataGrid.rootNode();
658 /** @type {!Array<!WebInspector.NetworkDataGridNode> } */ 658 /** @type {!Array<!WebInspector.NetworkDataGridNode> } */
659 var nodesToInsert = []; 659 var nodesToInsert = [];
660 /** @type {!Array<!WebInspector.NetworkDataGridNode> } */ 660 /** @type {!Array<!WebInspector.NetworkDataGridNode> } */
661 var nodesToRefresh = []; 661 var nodesToRefresh = [];
662 for (var requestId in this._staleRequestIds) { 662 for (var requestId in this._staleRequestIds) {
663 var node = this._nodesByRequestId.get(requestId); 663 var node = this._nodesByRequestId.get(requestId);
664 if (!node) 664 if (!node)
665 continue; 665 continue;
666 var isFilteredOut = !this._applyFilter(node); 666 var isFilteredOut = !this._applyFilter(node);
667 if (isFilteredOut && node === this._hoveredNode)
668 this._hoveredNode = null;
667 if (node[WebInspector.NetworkLogView._isFilteredOutSymbol] !== isFil teredOut) { 669 if (node[WebInspector.NetworkLogView._isFilteredOutSymbol] !== isFil teredOut) {
668 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol]) 670 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
669 rootNode.removeChild(node); 671 rootNode.removeChild(node);
670 672
671 node[WebInspector.NetworkLogView._isFilteredOutSymbol] = isFilte redOut; 673 node[WebInspector.NetworkLogView._isFilteredOutSymbol] = isFilte redOut;
672 674
673 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol]) 675 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
674 nodesToInsert.push(node); 676 nodesToInsert.push(node);
675 } 677 }
676 if (!isFilteredOut) 678 if (!isFilteredOut)
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
708 710
709 reset: function() 711 reset: function()
710 { 712 {
711 this._requestWithHighlightedInitiators = null; 713 this._requestWithHighlightedInitiators = null;
712 this.dispatchEventToListeners(WebInspector.NetworkLogView.Events.Request Selected, null); 714 this.dispatchEventToListeners(WebInspector.NetworkLogView.Events.Request Selected, null);
713 715
714 this._clearSearchMatchedList(); 716 this._clearSearchMatchedList();
715 717
716 this._columns.reset(); 718 this._columns.reset();
717 719
720 this._hoveredNode = null;
721
718 this._timeFilter = null; 722 this._timeFilter = null;
719 this._calculator.reset(); 723 this._calculator.reset();
720 724
721 this._timeCalculator.setWindow(null); 725 this._timeCalculator.setWindow(null);
722 726
723 var nodes = this._nodesByRequestId.valuesArray(); 727 var nodes = this._nodesByRequestId.valuesArray();
724 for (var i = 0; i < nodes.length; ++i) 728 for (var i = 0; i < nodes.length; ++i)
725 nodes[i].dispose(); 729 nodes[i].dispose();
726 730
727 this._nodesByRequestId.clear(); 731 this._nodesByRequestId.clear();
(...skipping 1119 matching lines...) Expand 10 before | Expand all | Expand 10 after
1847 * @return {boolean} 1851 * @return {boolean}
1848 */ 1852 */
1849 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request) 1853 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request)
1850 { 1854 {
1851 if (request.issueTime() > windowEnd) 1855 if (request.issueTime() > windowEnd)
1852 return false; 1856 return false;
1853 if (request.endTime !== -1 && request.endTime < windowStart) 1857 if (request.endTime !== -1 && request.endTime < windowStart)
1854 return false; 1858 return false;
1855 return true; 1859 return true;
1856 } 1860 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698