Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2435593005: [Devtools] Fixed bug with _visibleColumns not set (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed bug with _visibleColumns not set Fixes a bug where it was throwing an error if the filter changed during the user looking at a request. R=dgozman,lushnikov BUG=657637 Committed: https://crrev.com/1261489527c9e5f0278925b90f9d6dbc90103d4e Cr-Commit-Position: refs/heads/master@{#426370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
allada
PTL
4 years, 2 months ago (2016-10-19 22:35:43 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-19 22:37:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435593005/1
4 years, 2 months ago (2016-10-19 23:30:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 01:44:55 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:14:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1261489527c9e5f0278925b90f9d6dbc90103d4e
Cr-Commit-Position: refs/heads/master@{#426370}

Powered by Google App Engine
This is Rietveld 408576698