Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 2435493003: [Views][Mac] Security Chip Default Value (Closed)
Patch Set: Fix for pkasting Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index e9ee2d4e03892ccd3de193edba3f4aa3b06a39d0..38bae1984894cf870c6f65b1ff78d0985497e24c 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -121,7 +121,8 @@ LocationBarViewMac::LocationBarViewMac(AutocompleteTextField* field,
new ManagePasswordsDecoration(command_updater, this)),
browser_(browser),
location_bar_visible_(true),
- should_show_secure_verbose_(true),
+ should_show_secure_verbose_(false),
+ should_show_nonsecure_verbose_(false),
should_animate_secure_verbose_(false),
should_animate_nonsecure_verbose_(false),
is_width_available_for_security_verbose_(false),
@@ -152,6 +153,9 @@ LocationBarViewMac::LocationBarViewMac(AutocompleteTextField* field,
command_line->GetSwitchValueASCII(switches::kSecurityChip);
should_show_secure_verbose_ =
security_chip_flag == switches::kSecurityChipShowAll;
+ should_show_nonsecure_verbose_ =
+ security_chip_flag == switches::kSecurityChipShowAll ||
+ security_chip_flag == switches::kSecurityChipShowNonSecureOnly;
}
if (command_line->HasSwitch(switches::kSecurityChipAnimation)) {
@@ -678,21 +682,27 @@ WebContents* LocationBarViewMac::GetWebContents() {
}
bool LocationBarViewMac::ShouldShowEVBubble() const {
- return (GetToolbarModel()->GetSecurityLevel(false) ==
- security_state::SecurityStateModel::EV_SECURE) &&
- should_show_secure_verbose_;
+ return GetToolbarModel()->GetSecurityLevel(false) ==
+ security_state::SecurityStateModel::EV_SECURE;
}
bool LocationBarViewMac::ShouldShowSecurityState() const {
+ if (omnibox_view_->IsEditingOrEmpty() ||
+ omnibox_view_->model()->is_keyword_hint()) {
+ return false;
+ }
+
security_state::SecurityStateModel::SecurityLevel security =
GetToolbarModel()->GetSecurityLevel(false);
- bool has_verbose_for_security =
- security == security_state::SecurityStateModel::DANGEROUS ||
- security == security_state::SecurityStateModel::HTTP_SHOW_WARNING ||
- (IsSecureConnection(security) && should_show_secure_verbose_);
- return has_verbose_for_security && !omnibox_view_->IsEditingOrEmpty() &&
- !omnibox_view_->model()->is_keyword_hint();
+ if (security == security_state::SecurityStateModel::EV_SECURE)
+ return true;
+ else if (security == security_state::SecurityStateModel::SECURE)
+ return should_show_secure_verbose_;
+
+ return should_show_nonsecure_verbose_ &&
+ (security == security_state::SecurityStateModel::DANGEROUS ||
+ security == security_state::SecurityStateModel::HTTP_SHOW_WARNING);
}
bool LocationBarViewMac::IsLocationBarDark() const {
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698