Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issue 2435393003: Rename VideoCaptureHostTest to VideoCaptureTest to reflect what it is (Closed)

Created:
4 years, 2 months ago by mcasas
Modified:
4 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename VideoCaptureHostTest to VideoCaptureTest to reflect what it is This CL renames VideoCaptureHostTest to VideoCaptureTest, since it really is an integration test of a bunch of classes, as detailed in the class-comments. I've tried a few times to disentangle this mess, in which VideoCaptureHost references MediaStreamManager knowing that the latter is a singleton; MediaStreamManager publicly allows everyone to access its VideoCaptureManager; VideoCaptureManager is a concrete class owning pairs of VideoCaptureController - VideoCaptureDevice; and VideoCaptureController uses via naked pointer VideoCaptureHosts. Not worth it for this unit test. BUG=651897 Committed: https://crrev.com/324c80a574fead20c0d75566b6365494de467957 Cr-Commit-Position: refs/heads/master@{#427001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -377 lines) Patch
M content/browser/renderer_host/media/video_capture_host.h View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +0 lines, -362 lines 0 comments Download
A + content/browser/renderer_host/media/video_capture_unittest.cc View 5 chunks +12 lines, -13 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
mcasas
emircan@ ptal at the concept avi@ RS plz the BUILD.gn microchange.
4 years, 2 months ago (2016-10-22 01:20:51 UTC) #4
Avi (use Gerrit)
microstamp lgtm
4 years, 2 months ago (2016-10-22 01:47:13 UTC) #5
emircan
lgtm
4 years, 2 months ago (2016-10-22 21:13:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435393003/1
4 years, 2 months ago (2016-10-22 22:19:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-23 13:50:16 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 13:53:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/324c80a574fead20c0d75566b6365494de467957
Cr-Commit-Position: refs/heads/master@{#427001}

Powered by Google App Engine
This is Rietveld 408576698