Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2435283002: [stubs] Add IsCallableMap predicate to CSA (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add IsCallableMap predicate to CSA Add an IsCallableMap predicate to code-stub-assembler which tests whether the given map is callable, and adjust all use sites. BUG= Committed: https://crrev.com/0e76a9c3699d288a7e6bdf12afb2992e0282e8e8 Cr-Commit-Position: refs/heads/master@{#40502}

Patch Set 1 #

Patch Set 2 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M src/builtins/builtins-conversion.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jgruber
4 years, 2 months ago (2016-10-21 10:43:01 UTC) #4
Igor Sheludko
lgtm
4 years, 2 months ago (2016-10-21 11:55:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435283002/20001
4 years, 2 months ago (2016-10-21 11:57:11 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 12:01:03 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:09:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e76a9c3699d288a7e6bdf12afb2992e0282e8e8
Cr-Commit-Position: refs/heads/master@{#40502}

Powered by Google App Engine
This is Rietveld 408576698