chrome/browser/ui/omnibox/chrome_omnibox_client.cc - Issue 2435103002: Omnibox: Preserve display text and select all on a focus search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/chrome_omnibox_client.cc

Issue 2435103002: Omnibox: Preserve display text and select all on a focus search (Closed)

Patch Set: Use display_text.length() as caret pos for KEYBOARD_SHORTCUT Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/chrome_omnibox_client.cc

diff --git a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc

index 0089256506337c24efc58b65dc839028a8342a46..faa180d86be6d066dbe5521146b5348ac27c12cb 100644

--- a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc

+++ b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc

@@ -140,11 +140,12 @@ ChromeOmniboxClient::CreateOmniboxNavigationObserver(

}

bool ChromeOmniboxClient::CurrentPageExists() const {

- return (controller_->GetWebContents() != NULL);

+ return (controller_->GetWebContents() != nullptr);

}

const GURL& ChromeOmniboxClient::GetURL() const {

- return controller_->GetWebContents()->GetVisibleURL();

+ return CurrentPageExists() ? controller_->GetWebContents()->GetVisibleURL()

+ : GURL::EmptyGURL();

}

const base::string16& ChromeOmniboxClient::GetTitle() const {