chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 2435103002: Omnibox: Preserve display text and select all on a focus search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 2435103002: Omnibox: Preserve display text and select all on a focus search (Closed)

Patch Set: Use display_text.length() as caret pos for KEYBOARD_SHORTCUT Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index a57bb001d8fc76c1ca606841e2d32a2709d17d1b..e8aba477d9136cdc0173b1856d2805d6dafd8521 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -375,10 +375,8 @@ void OmniboxViewMac::EnterKeywordModeForDefaultSearchProvider() {

FocusLocation(true);

// Transition the user into keyword mode using their default search provider.

- // Select their query if they typed one.

model()->EnterKeywordModeForDefaultSearchProvider(

KeywordModeEntryMethod::KEYBOARD_SHORTCUT);

- SelectAll(false);

}

bool OmniboxViewMac::IsSelectAll() const {