Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2435053003: Revert of Access SigninErrorProvider through ChromeBrowserProvider. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 2 months ago
Reviewers:
bzanotti
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Access SigninErrorProvider through ChromeBrowserProvider. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2437003003/ ) Reason for revert: Will break the autoroller (need to be split in two). Original issue's description: > Access SigninErrorProvider through ChromeBrowserProvider. > > BUG=475439 TBR=bzanotti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475439 Committed: https://crrev.com/9b1e871a4d431ef8ba238d2ffc237159d9569c70 Cr-Commit-Position: refs/heads/master@{#426559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm View 1 chunk +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/signin/signin_util.mm View 2 chunks +1 line, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/fake_chrome_identity_interaction_manager.mm View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sdefresne
Created Revert of Access SigninErrorProvider through ChromeBrowserProvider.
4 years, 2 months ago (2016-10-20 19:17:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435053003/1
4 years, 2 months ago (2016-10-20 19:17:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 19:19:44 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b1e871a4d431ef8ba238d2ffc237159d9569c70
Cr-Commit-Position: refs/heads/master@{#426559}

Powered by Google App Engine
This is Rietveld 408576698