Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2435043002: Add Feature tag to all Webapp tests (Closed)

Created:
4 years, 2 months ago by kraush
Modified:
4 years, 2 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Feature tag to all Webapp tests Most Webapp tests already had the "Webapps" feature tag. This change adds it to the remaining tests to allow positive or negative filtering for all of them at once. Committed: https://crrev.com/445c65bd16d33c49ef7ad5d4c6163c8e2086445f Cr-Commit-Position: refs/heads/master@{#426798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappAuthenticatorTest.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappDirectoryManagerTest.java View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java View 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kraush
Hi Dominick, Can you take a look at this change to align all Webapp tests ...
4 years, 2 months ago (2016-10-20 14:53:56 UTC) #2
dominickn
On 2016/10/20 14:53:56, kraush wrote: > Hi Dominick, > > Can you take a look ...
4 years, 2 months ago (2016-10-20 23:47:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435043002/1
4 years, 2 months ago (2016-10-21 14:55:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 15:40:01 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 16:04:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/445c65bd16d33c49ef7ad5d4c6163c8e2086445f
Cr-Commit-Position: refs/heads/master@{#426798}

Powered by Google App Engine
This is Rietveld 408576698