Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2435033002: Fix NULL pointer dereference in FinishedAsyncCopyRequest() (Closed)

Created:
4 years, 2 months ago by jb
Modified:
4 years, 2 months ago
Reviewers:
sadrul, jbauman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NULL pointer dereference in FinishedAsyncCopyRequest() Due to undefined (favorably right to left) argument evaluation order, the tracker might have been passed and set to NULL before the window is looked up which results in a NULL pointer dereference. BUG= Committed: https://crrev.com/1b4c64279b7c212242738b96643a0700d04d725c Cr-Commit-Position: refs/heads/master@{#426748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ui/snapshot/snapshot_aura.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
jb
PTAL
4 years, 2 months ago (2016-10-20 13:44:03 UTC) #3
sadrul
lgtm
4 years, 2 months ago (2016-10-20 16:42:19 UTC) #4
jbauman
lgtm
4 years, 2 months ago (2016-10-20 19:45:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435033002/1
4 years, 2 months ago (2016-10-21 06:41:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 07:56:22 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:28:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b4c64279b7c212242738b96643a0700d04d725c
Cr-Commit-Position: refs/heads/master@{#426748}

Powered by Google App Engine
This is Rietveld 408576698