Teach analyzer parser to handle native const factories/const constructors.

Teach analyzer parser to handle native const factories/const constructors.

This is needed to parse VM patch files, which contain things like:

@patch const factory String.fromEnvironment(String name,
                                              {String defaultValue})
      native "String_fromEnvironment";

Currently analyzer would throw "Only redirecting factory constructors can be
declared to be 'const'." error when it sees this code.

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/1f6e03883eec3f18ef09a0166344a5b6e96ce1fe

[Vyacheslav Egorov (Google), 2016-10-20 15:58:41]

vegorov@google.com changed reviewers:
+ paulberry@google.com

[Vyacheslav Egorov (Google), 2016-10-20 15:58:41]

PTAL

[Paul Berry, 2016-10-20 16:14:38]

Can you add a test to pkg/analyzer/test/generated/non_error_resolver_test.dart
which verifies that no error is generated?

[Vyacheslav Egorov (Google), 2016-10-20 16:36:13]

Added a test. PTAL

[Paul Berry, 2016-10-20 17:30:16]

lgtm

[Vyacheslav Egorov (Google), 2016-10-20 18:09:10]

Description was changed from

==========
Teach analyzer parser to handle native const factories/const constructors.

This is needed to parse VM patch files, which contain things like:

@patch const factory String.fromEnvironment(String name,
                                              {String defaultValue})
      native "String_fromEnvironment";

Currently analyzer would throw "Only redirecting factory constructors can be
declared to be 'const'." error when it sees this code.

BUG=
==========

to

==========
Teach analyzer parser to handle native const factories/const constructors.

This is needed to parse VM patch files, which contain things like:

@patch const factory String.fromEnvironment(String name,
                                              {String defaultValue})
      native "String_fromEnvironment";

Currently analyzer would throw "Only redirecting factory constructors can be
declared to be 'const'." error when it sees this code.

BUG=
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1f6e03883eec3f18ef09a0166344a5b6e96ce1fe
==========

[Vyacheslav Egorov (Google), 2016-10-20 18:09:11]

Committed patchset #2 (id:20001) manually as
1f6e03883eec3f18ef09a0166344a5b6e96ce1fe (presubmit successful).