[wrapper-tracing] Add NodeList write barriers

[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org

Committed: https://crrev.com/bd96d939d5675f573bc54288faad366717765928
Cr-Commit-Position: refs/heads/master@{#426475}

[Michael Lippautz, 2016-10-20 11:21:05]

Description was changed from

==========
[wrapper-tracing] Add NodeList write barriers

BUG=
==========

to

==========
[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
==========

[Michael Lippautz, 2016-10-20 11:21:19]

Description was changed from

==========
[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
==========

to

==========
[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org
==========

[Michael Lippautz, 2016-10-20 11:26:48]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org, hlopko@chromium.org

[Michael Lippautz, 2016-10-20 11:26:48]

ptal

The reason these are explicit barriers is the following: We are mirroring object
groups based on NodeList.idl. This means we should trace wrappers for those
members. However, they are weak for oilpan, meaning that we require explicit
barriers. (There is no TraceWrapperWeakMember.)

[haraken, 2016-10-20 11:42:01]

Just an idea, but what do you think about introducing TraceWrapperWeakMember? It
will at least be helpful to remove write barriers and make the code base less
error-prone. However, it will increase # of pointer types.

If you think this CL is better than introducing TraceWrapperWeakMember, LGTM.

[Michael Lippautz, 2016-10-20 12:34:09]

On 2016/10/20 11:42:01, haraken wrote:
> Just an idea, but what do you think about introducing TraceWrapperWeakMember?
It
> will at least be helpful to remove write barriers and make the code base less
> error-prone. However, it will increase # of pointer types.
> 
> If you think this CL is better than introducing TraceWrapperWeakMember, LGTM.

In the NodeRareData case it wouldn't help as we are worried about memory
footprint. In the other cases, yes, it would simplify things on the
end-developer side. I'll give it some thought.

Since these are the last barriers I am aware of, I will land and check the
remaining test failures. Will try to simplify things where possible in
followups.

[Michael Lippautz, 2016-10-20 12:34:16]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-10-20 12:34:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 12:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 12:46:50]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Michael Lippautz, 2016-10-20 12:51:35]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-10-20 12:51:35]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2435003002/#ps20001
(title: "Fix compile errors")

[commit-bot: I haz the power, 2016-10-20 12:52:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 13:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 13:05:24]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Michael Lippautz, 2016-10-20 13:22:45]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-10-20 13:22:46]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2435003002/#ps40001
(title: "2nd try")

[commit-bot: I haz the power, 2016-10-20 13:22:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 14:37:02]

Description was changed from

==========
[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org
==========

to

==========
[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org
==========

[commit-bot: I haz the power, 2016-10-20 14:37:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:18:17]

Description was changed from

==========
[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org
==========

to

==========
[wrapper-tracing] Add NodeList write barriers

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org

Committed: https://crrev.com/bd96d939d5675f573bc54288faad366717765928
Cr-Commit-Position: refs/heads/master@{#426475}
==========

[commit-bot: I haz the power, 2016-10-21 13:18:18]

Patchset 3 (id:??) landed as
https://crrev.com/bd96d939d5675f573bc54288faad366717765928
Cr-Commit-Position: refs/heads/master@{#426475}