Issue 24350008: CSSGradientValue should check whether gradientLength is zero or not.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24350008: CSSGradientValue should check whether gradientLength is zero or not. (Closed)

Created:
7 years, 3 months ago by tasak

Modified:
7 years, 3 months ago

Reviewers:
eae, eseidel

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

CSSGradientValue should check whether gradientLength is zero or not. BUG=295126 TEST=fast/gradients/css3-repeating-radial-gradients-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158220

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1 line)			Patch
A	LayoutTests/fast/gradients/css3-repeating-radial-gradients-crash.html	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/gradients/css3-repeating-radial-gradients-crash-expected.html	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSGradientValue.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

tasak

I checked my new test by using Firefox and the expected result is the same.

7 years, 3 months ago (2013-09-23 18:26:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/24350008/1

7 years, 3 months ago (2013-09-23 21:11:13 UTC) #3

Message was sent while issue was closed.

Change committed as 158220