Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2434973002: MIPS: Fix several failures due to unsupported Sed and Seh innstructions on MIPS32R1 (Closed)

Created:
4 years, 2 months ago by ivica.bogosavljevic
Modified:
4 years, 1 month ago
Reviewers:
miran.karic, miran.karic
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Simulate SEB and SEH instructions on MIPS32R1 through MacroAssembler SEB and SEH instructions are not available on MIPS32R1. This caused several failures on MIPS32R1 in mjsunit/wasm/* and mjsunit/asm test suites. This fix simulates these instruction in MacroAssembler for those architectures that do not support them. TEST=mjsunit/asm/sqlite3/sqlite-pointer-masking,mjsunit/wasm/embenchen/lua_binarytrees BUG= Committed: https://crrev.com/f36713b5e998be67cf9d684c40fad9af45c6683e Cr-Commit-Position: refs/heads/master@{#40467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +28 lines, -16 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
ivica.bogosavljevic
PTAL
4 years, 2 months ago (2016-10-20 11:02:12 UTC) #4
miran.karic
On 2016/10/20 11:02:12, ivica.bogosavljevic wrote: > PTAL LGTM, just fix SED and SED in description ...
4 years, 2 months ago (2016-10-20 11:31:08 UTC) #5
miran.karic
On 2016/10/20 11:31:08, miran.karic wrote: > On 2016/10/20 11:02:12, ivica.bogosavljevic wrote: > > PTAL > ...
4 years, 2 months ago (2016-10-20 11:35:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434973002/1
4 years, 2 months ago (2016-10-20 12:23:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 12:28:32 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:02 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f36713b5e998be67cf9d684c40fad9af45c6683e
Cr-Commit-Position: refs/heads/master@{#40467}

Powered by Google App Engine
This is Rietveld 408576698