wptserve: Document how to re-generate keys and certs.

wptserve: Document how to re-generate keys and certs.

BUG=623613
NOTRY=true

Committed: https://crrev.com/54b4c65a2bfe9f4cb89f4b9877dbf40f9e321879
Cr-Commit-Position: refs/heads/master@{#426502}

[tkent, 2016-10-20 00:56:36]

tkent@chromium.org changed reviewers:
+ jsbell@chromium.org, qyearsley@chromium.org

[tkent, 2016-10-20 00:56:37]

jsbell@, qyearsley@, would you review this please?

[jsbell, 2016-10-20 16:30:13]

lgtm

I wonder if we should add a --overwrite-pregenerated-certs=3000 flag to
wptserve, and have it print a helpful diagnostic suggesting the command if the
pregenerated certs have expired?

[jsbell, 2016-10-20 16:30:20]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:30:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2016-10-20 16:34:39]

lgtm :-)

https://codereview.chromium.org/2434933002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium
(right):

https://codereview.chromium.org/2434933002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium:55: the
default setting, but we check in pre-generated files to avoid "openssl"
Possible minor rephrasing:
"WPTServe generates them on the fly with "openssl" command in the default
setting, ..."
-> "By default, WPTServe generates these files using the "openssl" command, ..."

[commit-bot: I haz the power, 2016-10-20 16:50:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:19:05]

Description was changed from

==========
wptserve: Document how to re-generate keys and certs.

BUG=623613
NOTRY=true
==========

to

==========
wptserve: Document how to re-generate keys and certs.

BUG=623613
NOTRY=true

Committed: https://crrev.com/54b4c65a2bfe9f4cb89f4b9877dbf40f9e321879
Cr-Commit-Position: refs/heads/master@{#426502}
==========

[commit-bot: I haz the power, 2016-10-21 13:19:06]

Patchset 1 (id:??) landed as
https://crrev.com/54b4c65a2bfe9f4cb89f4b9877dbf40f9e321879
Cr-Commit-Position: refs/heads/master@{#426502}

[tkent, 2016-10-24 04:14:40]

> I wonder if we should add a --overwrite-pregenerated-certs=3000 flag to
wptserve, and have it print a helpful diagnostic suggesting the command if the
pregenerated certs have expired?

Such option makes sense only in Chromium project. So, adding it to wptserve is
questionable.
Checking certificate validity by pure Python is not easy.

https://codereview.chromium.org/2434933002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium
(right):

https://codereview.chromium.org/2434933002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium:55: the
default setting, but we check in pre-generated files to avoid "openssl"
On 2016/10/20 at 16:34:39, qyearsley wrote:
> Possible minor rephrasing:
> "WPTServe generates them on the fly with "openssl" command in the default
setting, ..."
> -> "By default, WPTServe generates these files using the "openssl" command,
..."

I'll make a CL for this.

[tkent, 2016-10-24 04:37:11]

On 2016/10/24 at 04:14:40, tkent wrote:
> > I wonder if we should add a --overwrite-pregenerated-certs=3000 flag to
wptserve, and have it print a helpful diagnostic suggesting the command if the
pregenerated certs have expired?
> 
> Such option makes sense only in Chromium project. So, adding it to wptserve is
questionable.
> Checking certificate validity by pure Python is not easy.

I think the generation can be done by sequence of openssl commands.  We should
make a script for it, by 2025 :)