Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: services/ui/ws/platform_display.h

Issue 2434923002: Handle modified displays in mustash. (Closed)
Patch Set: Fix PlatformScreenStub for tests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ws/frame_generator_delegate.h ('k') | services/ui/ws/platform_display.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/platform_display.h
diff --git a/services/ui/ws/platform_display.h b/services/ui/ws/platform_display.h
index db6a43de144a537f533b12913a9a246b4112fced..96b52cf8fb56235640f317566da47b4d4173d4cc 100644
--- a/services/ui/ws/platform_display.h
+++ b/services/ui/ws/platform_display.h
@@ -79,10 +79,6 @@ class PlatformDisplay {
virtual void SetCursorById(mojom::Cursor cursor) = 0;
- virtual display::Display::Rotation GetRotation() = 0;
-
- virtual float GetDeviceScaleFactor() = 0;
-
virtual void UpdateTextInputState(const ui::TextInputState& state) = 0;
virtual void SetImeVisibility(bool visible) = 0;
@@ -91,6 +87,13 @@ class PlatformDisplay {
virtual gfx::Rect GetBounds() const = 0;
+ // Updates the viewport metrics for the display, returning true if any
+ // metrics have changed.
+ virtual bool UpdateViewportMetrics(
+ const display::ViewportMetrics& metrics) = 0;
+
+ virtual const display::ViewportMetrics& GetViewportMetrics() const = 0;
+
virtual bool IsPrimaryDisplay() const = 0;
// Notifies the PlatformDisplay that a connection to the gpu has been
@@ -128,21 +131,17 @@ class DefaultPlatformDisplay : public PlatformDisplay,
void SetCapture() override;
void ReleaseCapture() override;
void SetCursorById(mojom::Cursor cursor) override;
- float GetDeviceScaleFactor() override;
- display::Display::Rotation GetRotation() override;
void UpdateTextInputState(const ui::TextInputState& state) override;
void SetImeVisibility(bool visible) override;
bool IsFramePending() const override;
gfx::Rect GetBounds() const override;
+ bool UpdateViewportMetrics(const display::ViewportMetrics& metrics) override;
+ const display::ViewportMetrics& GetViewportMetrics() const override;
bool IsPrimaryDisplay() const override;
void OnGpuChannelEstablished(
scoped_refptr<gpu::GpuChannelHost> gpu_channel) override;
private:
- void UpdateMetrics(const gfx::Rect& bounds,
- const gfx::Size& pixel_size,
- float device_scale_factor);
-
// Update the root_location of located events to be relative to the origin
// of this display. For example, if the origin of this display is (1800, 0)
// and the location of the event is (100, 200) then the root_location will be
@@ -165,7 +164,6 @@ class DefaultPlatformDisplay : public PlatformDisplay,
// FrameGeneratorDelegate:
ServerWindow* GetRootWindow() override;
bool IsInHighContrastMode() override;
- const ViewportMetrics& GetViewportMetrics() override;
int64_t id_;
@@ -176,7 +174,7 @@ class DefaultPlatformDisplay : public PlatformDisplay,
PlatformDisplayDelegate* delegate_ = nullptr;
std::unique_ptr<FrameGenerator> frame_generator_;
- ViewportMetrics metrics_;
+ display::ViewportMetrics metrics_;
std::unique_ptr<ui::PlatformWindow> platform_window_;
DISALLOW_COPY_AND_ASSIGN(DefaultPlatformDisplay);
« no previous file with comments | « services/ui/ws/frame_generator_delegate.h ('k') | services/ui/ws/platform_display.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698